[Openmp-commits] [PATCH] D71987: [OpenMP][NFC] Add a couple of TODOs to the runtime

[Joachim Protze via Phabricator via Openmp-commits]

protze.joachim added inline comments.


================
Comment at: openmp/runtime/src/kmp.h:2245
+  // needed?
   unsigned merged_if0 : 1; /* no __kmpc_task_{begin/complete}_if0 calls in if0
                               code path */
----------------
jdoerfert wrote:
> protze.joachim wrote:
> > It's at least used by OMPT to identify an undeferred task.
> > Ignoring undeferred tasks can be performance critical for tools.
> I think it is only written here:
> ```
>     // Detachable tasks are not proxy tasks yet but could be in the future. Doing 
>     // the tasking setup
>     // when that happens is too late.
>     if (flags->proxy == TASK_PROXY || flags->detachable == TASK_DETACHABLE) {
>       if (flags->proxy == TASK_PROXY) {
>         flags->tiedness = TASK_UNTIED;
>         flags->merged_if0 = 1;                                                                                                                                                                                                          
>       }
> ```
> 
> Couldn't you use the above conditions to replace `merged_if0` ?
Ok, I checked the OMPT code again. The flag is actually used to signal `ompt_task_mergeable`. So I agree, we can remove this flag from my perspective.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71987/new/

https://reviews.llvm.org/D71987