[Openmp-commits] [PATCH] D92197: [OpenMP] Avoid internal calls to external compiler interface (kmpc)

[Hansang Bae via Phabricator via Openmp-commits]

hbae added inline comments.


================
Comment at: openmp/runtime/src/kmp_csupport.cpp:476-482
 /*!
 @ingroup PARALLEL
 @param loc  source location information
 @param global_tid  global thread number
 
 Leave a serialized parallel construct.
 */
----------------
protze.joachim wrote:
> Where should the documentation go?
I do not know if someone is actively using doxygen output now, but if we want to keep current documentation, it should move to `__kmpc_*` functions.


================
Comment at: openmp/runtime/src/kmp_gsupport.cpp:1285
+#endif
+      __kmp_omp_task_begin_if0_template<false>(&loc, gtid, task, NULL, NULL,
+                                               NULL);
----------------
It seems that we need instantiation of this function and other two templates used below with `<false>` input. Alternatively, we can define these three functions that do not contain OMPT code.
```
__kmp_omp_task_begin_if0(...)
__kmp_omp_task_complete_if0(...)
__kmp_omp_taskwait(...)
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92197/new/

https://reviews.llvm.org/D92197