[Openmp-commits] [PATCH] D92197: [OpenMP] Avoid internal calls to external compiler interface (kmpc)

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a comment.

Thanks for pushing this into the new direction. Don't wait for me though.



================
Comment at: openmp/runtime/src/kmp_cexternal.h:1
+#include "kmp_os.h"
+
----------------
License and short explanation what this file is.


================
Comment at: openmp/runtime/src/kmp_csupport.cpp:476-482
 /*!
 @ingroup PARALLEL
 @param loc  source location information
 @param global_tid  global thread number
 
 Leave a serialized parallel construct.
 */
----------------
hbae wrote:
> protze.joachim wrote:
> > Where should the documentation go?
> I do not know if someone is actively using doxygen output now, but if we want to keep current documentation, it should move to `__kmpc_*` functions.
We just created the doxygen build target. The website is on its way, assume doxygen is a thing now, and yes the main docue goes to the public facing ones. We can (as we get to it) add `/// \see __kmp_end_serialized_parallel` to the `aux` ones (or something similar that creates a link.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92197/new/

https://reviews.llvm.org/D92197