[Openmp-commits] [PATCH] D92197: [OpenMP] Avoid internal calls to external compiler interface (kmpc)

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

I think the idea behind this change is:

- There is an external interface. The compiler only emits calls to functions in this interface.
- Functions within the library should never call a function from this external interface

If so, I'm strongly in favour. That design lends itself to wrapping the external interface for logging, debugging etc. It means the functions that do the work can be marked internal when building the library as bitcode, allowing other transforms. That it is useful for ompt is a consequence of the separation being useful elsewhere.

The change itself seems noisy for that, possibly because it mixes the refactor to avoid calls to the interface with the ompt changes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92197/new/

https://reviews.llvm.org/D92197