[Openmp-commits] [PATCH] D64219: [OpenMP][NFCI] Cleanup the target worksharing implementation

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert marked 3 inline comments as done.
jdoerfert added inline comments.


================
Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/worksharing.cpp:25
+template <typename IVTy, typename SIVTy>
+INLINE static void ForStaticChunk(int &last, IVTy &LB, IVTy &UB, SIVTy &Stride,
+                                  SIVTy ChunkSize, IVTy EntityId,
----------------
ABataev wrote:
> Maybe, it is worth it to rename functions here ti follow LLVM coding rules?
will do.


================
Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/worksharing.cpp:568
+
+DISPATCH_GEN(_4, int32_t, int32_t, int32_t)
+DISPATCH_GEN(_4u, uint32_t, int32_t, int32_t)
----------------
ABataev wrote:
> TidTy us always `int32_t`, you can hardcode it in the macro.
sure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64219/new/

https://reviews.llvm.org/D64219