[Openmp-commits] [PATCH] D64219: [OpenMP][NFCI] Cleanup the target worksharing implementation

Johannes Doerfert via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Jul 5 10:50:35 PDT 2019


jdoerfert marked 2 inline comments as done.
jdoerfert added inline comments.


================
Comment at: openmp/libomptarget/deviceRTLs/nvptx/CMakeLists.txt:50
       src/libcall.cu
-      src/loop.cu
+      src/worksharing.cu
       src/omptarget-nvptx.cu
----------------
ABataev wrote:
> Hmm, the file has name `worksharing.cpp`, here it is named `worksharing.cu`. Did you try to compile it?
I fixed it on my remote test machine but forgot to fix it locally before the commit. Same as the below leftover addition of the `void` return type. (I did run `ninja check-all` and `ninja check-openmp` and passed everything).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64219/new/

https://reviews.llvm.org/D64219





More information about the Openmp-commits mailing list