[Openmp-commits] [PATCH] D71989: [OpenMP][IRBuilder][WIP] Prototype `omp task` support

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert marked 2 inline comments as done.
jdoerfert added inline comments.


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:86-87
+    enum : uint64_t {
+      IN = 1uL << 61,
+      OUT = 1uL << 61,
+      IN_OUT = IN | OUT,
----------------
lebedev.ri wrote:
> This doesn't seem correctt.
It is not, thx, 62. 


================
Comment at: openmp/runtime/src/kmp.h:2242
 
 typedef struct kmp_tasking_flags { /* Total struct must be exactly 32 bits */
   /* Compiler flags */ /* Total compiler flags must be 16 bits */
----------------
JonChesterfield wrote:
> Existing code, but the comments about number of bits here should probably be executable. E.g. give the compiler and the library a uint16_t field each, assert that sizeof kmp_tasking_flags == sizeof(uint32_t). Optionally four byte align the first short.
I'd like to make a bunch of changes like that now that I started to look into the library closer. In addition to the TODOs I added below (in another patch), I found seemingly unused functions, arguments, ... Versioning the runtime seems interesting to me now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71989/new/

https://reviews.llvm.org/D71989