[Openmp-commits] [PATCH] D70971: [libomptarget] Build a minimal deviceRTL for amdgcn

Tue Dec 3 18:18:38 PST 2019

ABataev added inline comments.

================
Comment at: openmp/libomptarget/deviceRTLs/amdgcn/src/device_environment.h:18
+
+struct omptarget_device_environmentTy {
+  int32_t debug_level;   // gets value of envvar LIBOMPTARGET_DEVICE_RTL_DEBUG
----------------
JonChesterfield wrote:
> ABataev wrote:
> > I think this can be moved to the common part of the code since the structure is absolutely the same.
> It's only the same because I've deleted the fields you disliked. This interface between plugin and deviceRTL is unlikely to be uniform across architectures and is known to be different for nvptx and amdgcn.
Currently they are the same. So, we don't need to copy entities and can use the common one.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70971/new/

https://reviews.llvm.org/D70971