[Openmp-commits] [PATCH] D70971: [libomptarget] Build a minimal deviceRTL for amdgcn

Tue Dec 3 17:33:10 PST 2019

JonChesterfield marked an inline comment as done.
JonChesterfield added a comment.

In D70971#1768180 <https://reviews.llvm.org/D70971#1768180>, @ABataev wrote:

> > I don't understand your requirements here. Are hardware limitations acceptable as a reason for different behaviour between systems? E.g. floating point arithmetic will inevitably return different values on different architectures when compiled with fast-math.
>
> Each particular case must be investigated individually. Precision is platform dependent here and thus it is ok if the results may vary.

Case by case I can deal with. Thanks for clarifying.

================
Comment at: openmp/libomptarget/deviceRTLs/amdgcn/src/device_environment.h:18
+
+struct omptarget_device_environmentTy {
+  int32_t debug_level;   // gets value of envvar LIBOMPTARGET_DEVICE_RTL_DEBUG
----------------
ABataev wrote:
> I think this can be moved to the common part of the code since the structure is absolutely the same.
It's only the same because I've deleted the fields you disliked. This interface between plugin and deviceRTL is unlikely to be uniform across architectures and is known to be different for nvptx and amdgcn.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70971/new/

https://reviews.llvm.org/D70971