[Openmp-commits] [PATCH] D70971: [libomptarget] Build a minimal deviceRTL for amdgcn

[Alexey Bataev via Phabricator via Openmp-commits]

ABataev added a comment.

> I don't understand your requirements here. Are hardware limitations acceptable as a reason for different behaviour between systems? E.g. floating point arithmetic will inevitably return different values on different architectures when compiled with fast-math.

Each particular case must be investigated individually. Precision is platform dependent here and thus it is ok if the results may vary.



================
Comment at: openmp/libomptarget/deviceRTLs/amdgcn/src/device_environment.h:18
+
+struct omptarget_device_environmentTy {
+  int32_t debug_level;   // gets value of envvar LIBOMPTARGET_DEVICE_RTL_DEBUG
----------------
I think this can be moved to the common part of the code since the structure is absolutely the same.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70971/new/

https://reviews.llvm.org/D70971