[Openmp-commits] [openmp] r369003 - [OpenMP] Enable warning about "implicit fallthrough"

[Jonas Hahnfeld via Openmp-commits]

Author: hahnfeld
Date: Thu Aug 15 06:26:55 2019
New Revision: 369003

URL: http://llvm.org/viewvc/llvm-project?rev=369003&view=rev
Log:
[OpenMP] Enable warning about "implicit fallthrough"

Fix last warned location in ittnotify_static.cpp using the defined
macro KMP_FALLTHROUGH().

Differential Revision: https://reviews.llvm.org/D65871

Modified:
    openmp/trunk/cmake/HandleOpenMPOptions.cmake
    openmp/trunk/cmake/config-ix.cmake
    openmp/trunk/runtime/cmake/LibompHandleFlags.cmake
    openmp/trunk/runtime/cmake/config-ix.cmake
    openmp/trunk/runtime/src/thirdparty/ittnotify/ittnotify_static.cpp

Modified: openmp/trunk/cmake/HandleOpenMPOptions.cmake
URL: http://llvm.org/viewvc/llvm-project/openmp/trunk/cmake/HandleOpenMPOptions.cmake?rev=369003&r1=369002&r2=369003&view=diff
==============================================================================
--- openmp/trunk/cmake/HandleOpenMPOptions.cmake (original)
+++ openmp/trunk/cmake/HandleOpenMPOptions.cmake Thu Aug 15 06:26:55 2019
@@ -21,6 +21,7 @@ endif()
 # Additional warnings that are not enabled by -Wall.
 append_if(OPENMP_HAVE_WCAST_QUAL_FLAG "-Wcast-qual" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
 append_if(OPENMP_HAVE_WFORMAT_PEDANTIC_FLAG "-Wformat-pedantic" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
+append_if(OPENMP_HAVE_WIMPLICIT_FALLTHROUGH_FLAG "-Wimplicit-fallthrough" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
 append_if(OPENMP_HAVE_WSIGN_COMPARE_FLAG "-Wsign-compare" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
 
 # Warnings that we want to disable because they are too verbose or fragile.

Modified: openmp/trunk/cmake/config-ix.cmake
URL: http://llvm.org/viewvc/llvm-project/openmp/trunk/cmake/config-ix.cmake?rev=369003&r1=369002&r2=369003&view=diff
==============================================================================
--- openmp/trunk/cmake/config-ix.cmake (original)
+++ openmp/trunk/cmake/config-ix.cmake Thu Aug 15 06:26:55 2019
@@ -6,6 +6,7 @@ check_cxx_compiler_flag(-Werror OPENMP_H
 # Additional warnings that are not enabled by -Wall.
 check_cxx_compiler_flag(-Wcast-qual OPENMP_HAVE_WCAST_QUAL_FLAG)
 check_cxx_compiler_flag(-Wformat-pedantic OPENMP_HAVE_WFORMAT_PEDANTIC_FLAG)
+check_cxx_compiler_flag(-Wimplicit-fallthrough OPENMP_HAVE_WIMPLICIT_FALLTHROUGH_FLAG)
 check_cxx_compiler_flag(-Wsign-compare OPENMP_HAVE_WSIGN_COMPARE_FLAG)
 
 # Warnings that we want to disable because they are too verbose or fragile.

Modified: openmp/trunk/runtime/cmake/LibompHandleFlags.cmake
URL: http://llvm.org/viewvc/llvm-project/openmp/trunk/runtime/cmake/LibompHandleFlags.cmake?rev=369003&r1=369002&r2=369003&view=diff
==============================================================================
--- openmp/trunk/runtime/cmake/LibompHandleFlags.cmake (original)
+++ openmp/trunk/runtime/cmake/LibompHandleFlags.cmake Thu Aug 15 06:26:55 2019
@@ -30,7 +30,6 @@ function(libomp_get_cxxflags cxxflags)
   libomp_append(flags_local -Wno-class-memaccess LIBOMP_HAVE_WNO_CLASS_MEMACCESS_FLAG)
   libomp_append(flags_local -Wno-covered-switch-default LIBOMP_HAVE_WNO_COVERED_SWITCH_DEFAULT_FLAG)
   libomp_append(flags_local -Wno-frame-address LIBOMP_HAVE_WNO_FRAME_ADDRESS_FLAG)
-  libomp_append(flags_local -Wno-implicit-fallthrough LIBOMP_HAVE_WNO_IMPLICIT_FALLTHROUGH_FLAG)
   libomp_append(flags_local -Wno-missing-braces LIBOMP_HAVE_WNO_MISSING_BRACES_FLAG)
   libomp_append(flags_local -Wno-strict-aliasing LIBOMP_HAVE_WNO_STRICT_ALIASING_FLAG)
   libomp_append(flags_local -Wstringop-overflow=0 LIBOMP_HAVE_WSTRINGOP_OVERFLOW_FLAG)

Modified: openmp/trunk/runtime/cmake/config-ix.cmake
URL: http://llvm.org/viewvc/llvm-project/openmp/trunk/runtime/cmake/config-ix.cmake?rev=369003&r1=369002&r2=369003&view=diff
==============================================================================
--- openmp/trunk/runtime/cmake/config-ix.cmake (original)
+++ openmp/trunk/runtime/cmake/config-ix.cmake Thu Aug 15 06:26:55 2019
@@ -51,7 +51,6 @@ check_cxx_compiler_flag(-fno-rtti LIBOMP
 check_cxx_compiler_flag(-Wno-class-memaccess LIBOMP_HAVE_WNO_CLASS_MEMACCESS_FLAG)
 check_cxx_compiler_flag(-Wno-covered-switch-default LIBOMP_HAVE_WNO_COVERED_SWITCH_DEFAULT_FLAG)
 check_cxx_compiler_flag(-Wno-frame-address LIBOMP_HAVE_WNO_FRAME_ADDRESS_FLAG)
-check_cxx_compiler_flag(-Wno-implicit-fallthrough LIBOMP_HAVE_WNO_IMPLICIT_FALLTHROUGH_FLAG)
 check_cxx_compiler_flag(-Wno-missing-braces LIBOMP_HAVE_WNO_MISSING_BRACES_FLAG)
 check_cxx_compiler_flag(-Wno-strict-aliasing LIBOMP_HAVE_WNO_STRICT_ALIASING_FLAG)
 check_cxx_compiler_flag(-Wstringop-overflow=0 LIBOMP_HAVE_WSTRINGOP_OVERFLOW_FLAG)

Modified: openmp/trunk/runtime/src/thirdparty/ittnotify/ittnotify_static.cpp
URL: http://llvm.org/viewvc/llvm-project/openmp/trunk/runtime/src/thirdparty/ittnotify/ittnotify_static.cpp?rev=369003&r1=369002&r2=369003&view=diff
==============================================================================
--- openmp/trunk/runtime/src/thirdparty/ittnotify/ittnotify_static.cpp (original)
+++ openmp/trunk/runtime/src/thirdparty/ittnotify/ittnotify_static.cpp Thu Aug 15 06:26:55 2019
@@ -8,6 +8,7 @@
 //===----------------------------------------------------------------------===//
 
 #include "kmp_config.h"
+#include "kmp_os.h"
 #include "ittnotify_config.h"
 
 #if ITT_PLATFORM==ITT_PLATFORM_WIN
@@ -1096,6 +1097,7 @@ ITT_EXTERN_C int _N_(init_ittlib)(const
                         switch (lib_version) {
                         case 0:
                             groups = __itt_group_legacy;
+                            KMP_FALLTHROUGH();
                         case 1:
                             /* Fill all pointers from dynamic library */
                             for (i = 0; _N_(_ittapi_global).api_list_ptr[i].name != NULL; i++)