[Openmp-commits] [PATCH] D65340: [OpenMP][libomptarget] Add support for close map modifier

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added inline comments.


================
Comment at: libomptarget/src/omptarget.cpp:299-300
+          HasCloseModifier) {
+        if (IsNew || (arg_types[i] & OMP_TGT_MAPTYPE_ALWAYS) ||
+            HasCloseModifier) {
           copy = true;
----------------
Hmm, thinking about this again: Does `close` imply `always`? I don't find this in the spec, so I think `HasCloseModifier` should not be in the inner condition.


================
Comment at: libomptarget/src/omptarget.cpp:414
 
-        if ((DelEntry || Always || CopyMember) &&
+        if ((DelEntry || Always || CopyMember || HasCloseModifier) &&
             !(Device.RTLRequiresFlags & OMP_REQ_UNIFIED_SHARED_MEMORY &&
----------------
Same here.


================
Comment at: libomptarget/test/unified_shared_memory/close_modifier.c:20
+
+  for(int i=0; i<N; ++i){
+    alloc[i] = 10.0;
----------------
Hahnfeld wrote:
> Please format.
Ping, test is still not formatted.


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65340/new/

https://reviews.llvm.org/D65340