[Openmp-commits] [PATCH] D65340: [OpenMP][libomptarget] Add support for close map modifier

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added a comment.

I'd propose to mark the test `close_modifier.c` as unsupported with older compiler versions. Additionally, can you add a small, new test with manual calls to `__tgt_target_data_begin` / `_end` without relying on the compiler?



================
Comment at: libomptarget/test/unified_shared_memory/close_modifier.c:28-30
+  // Manual registration of requires flags for Clang versions
+  // that do not support requires.
+  __tgt_register_requires(8);
----------------
Unfortunately, I don't think that's enough for this test to pass with older versions of Clang because it didn't support code generation for `close`. Did you test this?


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65340/new/

https://reviews.llvm.org/D65340