[Openmp-commits] [PATCH] D46210: [OpenMP] Use LIBOMPDEVICE_DEBUG env var to control debug messages on the device side

George Rokos via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri May 4 08:52:15 PDT 2018


grokos added inline comments.


================
Comment at: libomptarget/plugins/cuda/src/rtl.cpp:533
+      DP("Finding global device environment '%s' - symbol missing.\n", device_env_Name);
+      DP("continue, considering this is a device RTL which does not accept envrionment setting.\n");
+      //CUDA_ERR_STRING(err);
----------------
continue --> Continue



================
Comment at: libomptarget/plugins/cuda/src/rtl.cpp:534-535
+      DP("continue, considering this is a device RTL which does not accept envrionment setting.\n");
+      //CUDA_ERR_STRING(err);
+      //return NULL;
+    }
----------------
Remove dead code.


https://reviews.llvm.org/D46210





More information about the Openmp-commits mailing list