[Openmp-commits] [PATCH] D41485: [OpenMP][libomptarget] Add data sharing support in libomptarget

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added inline comments.


================
Comment at: libomptarget/deviceRTLs/nvptx/src/interface.h:1290-1291
 EXTERN void __kmpc_spmd_kernel_deinit();
-EXTERN void __kmpc_kernel_prepare_parallel(void *WorkFn, int16_t IsOMPRuntimeInitialized);
-EXTERN bool __kmpc_kernel_parallel(void **WorkFn, int16_t IsOMPRuntimeInitialized);
+EXTERN void __kmpc_kernel_prepare_parallel(void *WorkFn, int16_t IsOMPRuntimeInitialized, void ***SharedArgs, int32_t nArgs);
+EXTERN bool __kmpc_kernel_parallel(void **WorkFn, int16_t IsOMPRuntimeInitialized, void ***SharedArgs);
 EXTERN void __kmpc_kernel_end_parallel();
----------------
gtbercea wrote:
> Hahnfeld wrote:
> > We have to agree on an order here: In D41012 I chose to put `IsOMPRuntimeInitialized` last which matches the other functions.
> Is it ok if we go with the order in this patch?
In the end I don't really care, but IMO it's more consistent to have `IsOMPRuntimeInitialized` last in the list of arguments. That's the reason I submitted D41012 as it currently is.


Repository:
  rL LLVM

https://reviews.llvm.org/D41485