[Openmp-commits] [PATCH] D41485: [OpenMP][libomptarget] Add data sharing support in libomptarget

[Gheorghe-Teodor Bercea via Phabricator via Openmp-commits]

gtbercea added inline comments.


================
Comment at: libomptarget/deviceRTLs/nvptx/src/interface.h:1290-1291
 EXTERN void __kmpc_spmd_kernel_deinit();
-EXTERN void __kmpc_kernel_prepare_parallel(void *WorkFn, int16_t IsOMPRuntimeInitialized);
-EXTERN bool __kmpc_kernel_parallel(void **WorkFn, int16_t IsOMPRuntimeInitialized);
+EXTERN void __kmpc_kernel_prepare_parallel(void *WorkFn, int16_t IsOMPRuntimeInitialized, void ***SharedArgs, int32_t nArgs);
+EXTERN bool __kmpc_kernel_parallel(void **WorkFn, int16_t IsOMPRuntimeInitialized, void ***SharedArgs);
 EXTERN void __kmpc_kernel_end_parallel();
----------------
Hahnfeld wrote:
> We have to agree on an order here: In D41012 I chose to put `IsOMPRuntimeInitialized` last which matches the other functions.
Is it ok if we go with the order in this patch?


Repository:
  rL LLVM

https://reviews.llvm.org/D41485