[Openmp-commits] [PATCH] D41485: [OpenMP][libomptarget] Add data sharing support in libomptarget

Gheorghe-Teodor Bercea via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Dec 22 03:19:02 PST 2017

gtbercea added inline comments.

Comment at: libomptarget/deviceRTLs/nvptx/src/interface.h:1290-1291
 EXTERN void __kmpc_spmd_kernel_deinit();
-EXTERN void __kmpc_kernel_prepare_parallel(void *WorkFn, int16_t IsOMPRuntimeInitialized);
-EXTERN bool __kmpc_kernel_parallel(void **WorkFn, int16_t IsOMPRuntimeInitialized);
+EXTERN void __kmpc_kernel_prepare_parallel(void *WorkFn, int16_t IsOMPRuntimeInitialized, void ***SharedArgs, int32_t nArgs);
+EXTERN bool __kmpc_kernel_parallel(void **WorkFn, int16_t IsOMPRuntimeInitialized, void ***SharedArgs);
 EXTERN void __kmpc_kernel_end_parallel();
Hahnfeld wrote:
> gtbercea wrote:
> > Hahnfeld wrote:
> > > We have to agree on an order here: In D41012 I chose to put `IsOMPRuntimeInitialized` last which matches the other functions.
> > Is it ok if we go with the order in this patch?
> In the end I don't really care, but IMO it's more consistent to have `IsOMPRuntimeInitialized` last in the list of arguments. That's the reason I submitted D41012 as it currently is.
Great! Let's use yours then and I can change the order of the args in this patch. Can you make sure you push the other patch and then once this one lands it should all work.



More information about the Openmp-commits mailing list