[Openmp-commits] [PATCH] D23304: [OMPT] extend ompt tests by checks for frame pointers

Jonathan Peyton via Openmp-commits openmp-commits at lists.llvm.org
Thu Aug 18 13:26:21 PDT 2016

jlpeyton added a reviewer: omalyshe.
jlpeyton added a comment.

I'm adding Olga as well as she is now part of the OMPT subcommittee.

> Should we review patches that come from the same team in the same company / university?

>  Ideally I would prefer no and that's why I told Joachim to not put me as reviewer because we already discussed some of the changes and their implementation offline.

I think it would be good to have a final stamp of approval from someone intimate with this component of the code base / future OpenMP specification.  There are not many regular reviewers to go around for OpenMP code (especially external to Intel), and even if you've already had an internal discussion within your group about the patches, giving it the ok at least partially acknowledges that activity.  I also agree that one of us, Intel or anyone else involved with this project, can look at these patches so there is external input.  The more eyes that have seen the patch and acknowledge it by writing a comment on here, the better.

That is of course just my opinion.  Anyone else want to chime in?


More information about the Openmp-commits mailing list