[Openmp-commits] [PATCH] D23304: [OMPT] extend ompt tests by checks for frame pointers

Jonas Hahnfeld via Openmp-commits openmp-commits at lists.llvm.org
Fri Aug 19 00:09:21 PDT 2016

Hahnfeld resigned from this revision.
Hahnfeld removed a reviewer: Hahnfeld.
Hahnfeld added a comment.

In https://reviews.llvm.org/D23304#520044, @jlpeyton wrote:

> I think it would be good to have a final stamp of approval from someone intimate with this component of the code base / future OpenMP specification.  There are not many regular reviewers to go around for OpenMP code (especially external to Intel), and even if you've already had an internal discussion within your group about the patches, giving it the ok at least partially acknowledges that activity.  I also agree that one of us, Intel or anyone else involved with this project, can look at these patches so there is external input.  The more eyes that have seen the patch and acknowledge it by writing a comment on here, the better.

As a proposal, I will put an `LGTM` and "Resign as Reviewer" to make clear that the patch should in my opinion receive additional (external) review


More information about the Openmp-commits mailing list