[Openmp-commits] [PATCH] D23304: [OMPT] extend ompt tests by checks for frame pointers

Jonas Hahnfeld via Openmp-commits openmp-commits at lists.llvm.org
Thu Aug 18 06:25:50 PDT 2016

Hahnfeld added a comment.

In https://reviews.llvm.org/D23304#518464, @jlpeyton wrote:

> LGTM.  It would be good if Jonas Hahnfeld or John Mellor-Crummey could review this series of OMPT changes as well since they are more familiar with it.

This might be a more general question and I'll be happy reposting it on `openmp-dev` to get broader feedback if we want to further discuss it:

Should we review patches that come from the same team in the same company / university?
Ideally I would prefer no and that's why I told Joachim to not put me as reviewer because we already discussed some of the changes and their implementation offline.

(However I understand that this is different for Intel: If I remember correctly there are multiple teams in multiple locations and you probably have more internal review than we have for some research coding...)


More information about the Openmp-commits mailing list