[Openmp-commits] [PATCH] D14027: [OMPT] Windows Support for OMPT

[John Mellor-Crummey via Openmp-commits]

I took a look at the final patch that you committed. After looking around at other modules in ompt_tool_windows, you didn’t free the data that you malloced. You should do that before each return in ompt_tool_windows.
--
John Mellor-Crummey         Professor
Dept of Computer Science    Rice University
email: johnmc at rice.edu      phone: 713-348-5179

> On Oct 29, 2015, at 3:58 PM, Jonathan Peyton <jonathan.l.peyton at intel.com> wrote:
> 
> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL251654: [OMPT] Windows Support for OMPT (authored by jlpeyton).
> 
> Changed prior to commit:
>  http://reviews.llvm.org/D14027?vs=38751&id=38761#toc
> 
> Repository:
>  rL LLVM
> 
> http://reviews.llvm.org/D14027
> 
> Files:
>  openmp/trunk/runtime/CMakeLists.txt
>  openmp/trunk/runtime/cmake/LibompMicroTests.cmake
>  openmp/trunk/runtime/cmake/config-ix.cmake
>  openmp/trunk/runtime/src/kmp_config.h.cmake
>  openmp/trunk/runtime/src/ompt-general.c
>  openmp/trunk/runtime/src/ompt-specific.c
>  openmp/trunk/runtime/src/ompt-specific.h
> 
> 
> 
> !DSPAM:8504,5632888b109664543715000!
> <D14027.38761.patch>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20151029/5b50f9fd/attachment.html>