<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">I took a look at the final patch that you committed. After looking around at other modules in ompt_tool_windows, you didn’t free the data that you malloced. You should do that before each return in ompt_tool_windows.<br class=""><div apple-content-edited="true" class="">
<span class="Apple-style-span" style="border-collapse: separate; border-spacing: 0px;"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; border-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-stroke-width: 0px;"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div style="font-size: 12px;" class=""><font face="Courier" class="">--<br class="">John Mellor-Crummey Professor<br class="">Dept of Computer Science Rice University<br class="">email: <a href="mailto:johnmc@rice.edu" class="">johnmc@rice.edu</a> phone: 713-348-5179</font><br class=""></div></div></span></div></span>
</div>
<br class=""><div><blockquote type="cite" class=""><div class="">On Oct 29, 2015, at 3:58 PM, Jonathan Peyton <<a href="mailto:jonathan.l.peyton@intel.com" class="">jonathan.l.peyton@intel.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">This revision was automatically updated to reflect the committed changes.<br class="">Closed by commit rL251654: [OMPT] Windows Support for OMPT (authored by jlpeyton).<br class=""><br class="">Changed prior to commit:<br class=""> <a href="http://reviews.llvm.org/D14027?vs=38751&id=38761#toc" class="">http://reviews.llvm.org/D14027?vs=38751&id=38761#toc</a><br class=""><br class="">Repository:<br class=""> rL LLVM<br class=""><br class=""><a href="http://reviews.llvm.org/D14027" class="">http://reviews.llvm.org/D14027</a><br class=""><br class="">Files:<br class=""> openmp/trunk/runtime/CMakeLists.txt<br class=""> openmp/trunk/runtime/cmake/LibompMicroTests.cmake<br class=""> openmp/trunk/runtime/cmake/config-ix.cmake<br class=""> openmp/trunk/runtime/src/kmp_config.h.cmake<br class=""> openmp/trunk/runtime/src/ompt-general.c<br class=""> openmp/trunk/runtime/src/ompt-specific.c<br class=""> openmp/trunk/runtime/src/ompt-specific.h<br class=""><br class=""><br class=""><br class="">!DSPAM:8504,5632888b109664543715000!<br class=""><span id="cid:602486E9-E033-4DB4-8413-882A635C8C53@rice.edu"><D14027.38761.patch></span></div></blockquote></div><br class=""></body></html>