[Mlir-commits] [mlir] [mlir] Add searchable remark history and query-based links (PR #237762)

Henrich Lauko llvmlistbot at llvm.org
Tue Nov 3 01:35:17 PST 2026


================
@@ -264,6 +338,15 @@ void RemarkEngine::reportImpl(const Remark &remark) {
 }
 
 void RemarkEngine::report(const Remark &&remark) {
----------------
xlauko wrote:

History records every report regardless of policy, but RemarkEmittingPolicyFinal keeps only the last remark for each (loc, name, combined category, kind) key. So relatedTo(query) can produce a RelatedTo pointing to an ID that Final dropped and that never appears in any output. I’d rather fix the semantics than document them: either the policy updates the entry when it dedupes, or history keeps one entry per dedup key. Then “searchable” means “will be emitted”.

https://github.com/llvm/llvm-project/pull/237762


More information about the Mlir-commits mailing list