[Mlir-commits] [mlir] [mlir] Add searchable remark history and query-based links (PR #237762)

[Henrich Lauko]

================
@@ -515,6 +561,13 @@ class RemarkEngine {
   /// Atomic counter for generating unique remark IDs.
   std::atomic<uint64_t> nextRemarkId{1};
 
+  /// Search history is independent of the emitting policy. Only metadata is
+  /// retained, and only after explicitly enabling history.
+  struct RemarkHistory;
----------------
xlauko wrote:

history, historyEnabled and historyMutex are three members for one piece of state, and <mutex> (line 27) is now in a widely included IR header. Could the mutex and entries move into RemarkHistory, which is already defined only in the .cpp, leaving the header with just the pointer and the atomic fast-path flag?

https://github.com/llvm/llvm-project/pull/237762