[Mlir-commits] [mlir] [mlir] Add searchable remark history and query-based links (PR #237762)

[Henrich Lauko]

================
@@ -648,6 +720,13 @@ mlir::remark::RemarkOpts::relatedTo(const detail::InFlightRemark &r) const {
 }
 
 namespace mlir::remark {
+/// Link to all remarks matching the query when this helper is inserted into an
+/// in-flight remark. History must have been enabled before reporting the target
+/// remarks. No matches (including disabled history) adds no links. Matching
+/// indicates a relationship, not causality or operation identity.
+inline detail::RelatedRemarkQuery relatedTo(RemarkQuery query) {
----------------
xlauko wrote:

With the multithreaded pass manager, sibling function passes report concurrently. Whether a query sees a sibling’s remark, and the order of the resulting RelatedTo IDs, depends on timing. That makes the output nondeterministic, which #224616 just fixed for Final. Could the docs at least say cross-function queries are nondeterministic under threading? Or should a query without function() be discouraged?

https://github.com/llvm/llvm-project/pull/237762