[Mlir-commits] [mlir] [mlir] Use MLIR op names when generating FileCheck variables in generate-test-checks.py (PR #160820)

[Michael Maitland]

michaelmaitland wrote:

> I concerned about this because the script is not meant to provide something readable in a "ready to use" kind of way.

> We shouldn't have tests with [[VAL0]] but we equally should not have [[ADDI]] : instead the author should use descriptive names in the context of the test.

Why is that the case? If tests shouldn't have VAL0 nor ADDI, then what should they have? 

This is how the llvm update_test_checks script works, and its quite helpful. I am in favor of this change.

https://github.com/llvm/llvm-project/pull/160820