[Mlir-commits] [mlir] [mlir] Use MLIR op names when generating FileCheck variables in generate-test-checks.py (PR #160820)

[Mehdi Amini]

joker-eph wrote:

> Why is that the case? If tests shouldn't have VAL0 nor ADDI, then what should they have?

Semantically meaningful names.

> This is how the llvm update_test_checks script works, and its quite helpful.

It may be helpful for quickly writing tests: these are however fragile and unmaintainable. "Tests should be minimal, and only check what is absolutely necessary."

> Also, the update_test_checks are intended to provide something that is ready to use. Why do we feel differently about the MLIR version? I consider the checks this script generates as "ready to use" -- same goes for folks on the LLVM side.

I don't know how LLVM got there, I personally strongly object to having tests are not minimally checking the output (that is remove **everything** that isn't relevant to the check.  This seems fundamentally incompatible with scripting.


https://github.com/llvm/llvm-project/pull/160820