[Mlir-commits] [mlir] [mlir] Use MLIR op names when generating FileCheck variables in generate-test-checks.py (PR #160820)

[Mehdi Amini]

joker-eph wrote:

I concerned about this because the script is **not** meant to provide something readable in a "ready to use" kind of way.

We shouldn't have tests with `[[VAL0]]` but we equally should not have `[[ADDI]]` : instead the author should use descriptive names in the context of the test. 

Making the script better here may be counter-productive in that it would be encouraging people to not pay more attention to the naming. And reviewer are also less likely to notice when the output of the script is used "as-is".

https://github.com/llvm/llvm-project/pull/160820