[Mlir-commits] [mlir] 66d4294 - Revert "[mlir] Apply ClangTidy finding (NFC)"

[Adrian Kuegel]

Author: Adrian Kuegel
Date: 2025-03-04T12:16:33Z
New Revision: 66d4294a77dc9ba7a5b94b3d3279a1e76ae026d1

URL: https://github.com/llvm/llvm-project/commit/66d4294a77dc9ba7a5b94b3d3279a1e76ae026d1
DIFF: https://github.com/llvm/llvm-project/commit/66d4294a77dc9ba7a5b94b3d3279a1e76ae026d1.diff

LOG: Revert "[mlir] Apply ClangTidy finding (NFC)"

This reverts commit b25b38412807615d2e54702435f67b5c5b7170c0.

Applied the finding manually and got it wrong.

Added: 
    

Modified: 
    mlir/lib/Conversion/MPIToLLVM/MPIToLLVM.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Conversion/MPIToLLVM/MPIToLLVM.cpp b/mlir/lib/Conversion/MPIToLLVM/MPIToLLVM.cpp
index aa7ed81ebd525..084a60ebfb53e 100644
--- a/mlir/lib/Conversion/MPIToLLVM/MPIToLLVM.cpp
+++ b/mlir/lib/Conversion/MPIToLLVM/MPIToLLVM.cpp
@@ -62,7 +62,7 @@ class MPIImplTraits {
 
   explicit MPIImplTraits(ModuleOp &moduleOp) : moduleOp(moduleOp) {}
 
-  ~MPIImplTraits() override = default;
+  virtual ~MPIImplTraits() = default;
 
   ModuleOp &getModuleOp() { return moduleOp; }
 
@@ -98,7 +98,7 @@ class MPICHImplTraits : public MPIImplTraits {
 public:
   using MPIImplTraits::MPIImplTraits;
 
-  ~MPICHImplTraits() override = default;
+  virtual ~MPICHImplTraits() = default;
 
   Value getCommWorld(const Location loc,
                      ConversionPatternRewriter &rewriter) override {