[Mlir-commits] [mlir] b25b384 - [mlir] Apply ClangTidy finding (NFC)
Adrian Kuegel
llvmlistbot at llvm.org
Tue Mar 4 04:13:43 PST 2025
Author: Adrian Kuegel
Date: 2025-03-04T12:12:07Z
New Revision: b25b38412807615d2e54702435f67b5c5b7170c0
URL: https://github.com/llvm/llvm-project/commit/b25b38412807615d2e54702435f67b5c5b7170c0
DIFF: https://github.com/llvm/llvm-project/commit/b25b38412807615d2e54702435f67b5c5b7170c0.diff
LOG: [mlir] Apply ClangTidy finding (NFC)
prefer using 'override' or (rarely) 'final' instead of 'virtual'
Added:
Modified:
mlir/lib/Conversion/MPIToLLVM/MPIToLLVM.cpp
Removed:
################################################################################
diff --git a/mlir/lib/Conversion/MPIToLLVM/MPIToLLVM.cpp b/mlir/lib/Conversion/MPIToLLVM/MPIToLLVM.cpp
index 084a60ebfb53e..aa7ed81ebd525 100644
--- a/mlir/lib/Conversion/MPIToLLVM/MPIToLLVM.cpp
+++ b/mlir/lib/Conversion/MPIToLLVM/MPIToLLVM.cpp
@@ -62,7 +62,7 @@ class MPIImplTraits {
explicit MPIImplTraits(ModuleOp &moduleOp) : moduleOp(moduleOp) {}
- virtual ~MPIImplTraits() = default;
+ ~MPIImplTraits() override = default;
ModuleOp &getModuleOp() { return moduleOp; }
@@ -98,7 +98,7 @@ class MPICHImplTraits : public MPIImplTraits {
public:
using MPIImplTraits::MPIImplTraits;
- virtual ~MPICHImplTraits() = default;
+ ~MPICHImplTraits() override = default;
Value getCommWorld(const Location loc,
ConversionPatternRewriter &rewriter) override {
More information about the Mlir-commits
mailing list