[Mlir-commits] [mlir] cd4c10a - [mlir] Apply ClangTidy finding (NFC)

[Adrian Kuegel]

Author: Adrian Kuegel
Date: 2025-03-04T12:20:35Z
New Revision: cd4c10afea7eaaf87c1830e340863f0bf8745b0b

URL: https://github.com/llvm/llvm-project/commit/cd4c10afea7eaaf87c1830e340863f0bf8745b0b
DIFF: https://github.com/llvm/llvm-project/commit/cd4c10afea7eaaf87c1830e340863f0bf8745b0b.diff

LOG: [mlir] Apply ClangTidy finding (NFC)

prefer using 'override' or (rarely) 'final' instead of 'virtual'
second attempt

Added: 
    

Modified: 
    mlir/lib/Conversion/MPIToLLVM/MPIToLLVM.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Conversion/MPIToLLVM/MPIToLLVM.cpp b/mlir/lib/Conversion/MPIToLLVM/MPIToLLVM.cpp
index 084a60ebfb53e..d91f9512ccb8f 100644
--- a/mlir/lib/Conversion/MPIToLLVM/MPIToLLVM.cpp
+++ b/mlir/lib/Conversion/MPIToLLVM/MPIToLLVM.cpp
@@ -98,7 +98,7 @@ class MPICHImplTraits : public MPIImplTraits {
 public:
   using MPIImplTraits::MPIImplTraits;
 
-  virtual ~MPICHImplTraits() = default;
+  ~MPICHImplTraits() override = default;
 
   Value getCommWorld(const Location loc,
                      ConversionPatternRewriter &rewriter) override {
@@ -156,7 +156,7 @@ class OMPIImplTraits : public MPIImplTraits {
 public:
   using MPIImplTraits::MPIImplTraits;
 
-  virtual ~OMPIImplTraits() = default;
+  ~OMPIImplTraits() override = default;
 
   Value getCommWorld(const Location loc,
                      ConversionPatternRewriter &rewriter) override {