[Mlir-commits] [mlir] [mlir][ptr] Switch `LogicalResult` to `bool` in `MemorySpaceAttrInterrface` (PR #137513)

[Fabian Mora]

fabianmcg wrote:

Could this be product of a dirty cache?
Because the error is:
```
FAILED: tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestAttributes.cpp.obj
sccache C:\BuildTools\VC\Tools\MSVC\14.29.30133\bin\Hostx64\x64\cl.exe  /nologo /TP -DGTEST_HAS_RTTI=0 -DMLIR_INCLUDE_TESTS -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools\mlir\test\lib\Dialect\Test -IC:\ws\buildbot\premerge-monolithic-windows\llvm-project\mlir\test\lib\Dialect\Test -Itools\mlir\include -IC:\ws\buildbot\premerge-monolithic-windows\llvm-project\mlir\include -Iinclude -IC:\ws\buildbot\premerge-monolithic-windows\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:preprocessor /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -
 wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd5105 -wd4324 -wd4251 -wd4275 -w14062 -we4238 /Gw /O2 /Ob2  -MD  /EHs-c- /GR- -UNDEBUG -std:c++17 /showIncludes /Fotools\mlir\test\lib\Dialect\Test\CMakeFiles\MLIRTestDialect.dir\TestAttributes.cpp.obj /Fdtools\mlir\test\lib\Dialect\Test\CMakeFiles\MLIRTestDialect.dir\MLIRTestDialect.pdb /FS -c C:\ws\buildbot\premerge-monolithic-windows\llvm-project\mlir\test\lib\Dialect\Test\TestAttributes.cpp
C:\ws\buildbot\premerge-monolithic-windows\llvm-project\mlir\test\lib\Dialect\Test\TestAttributes.cpp(336): error C2556: 'bool test::TestConstMemorySpaceAttr::isValidLoad(mlir::Type,mlir::ptr::AtomicOrdering,mlir::IntegerAttr,llvm::function_ref<mlir::InFlightDiagnostic (void)>) const': overloaded function differs only by return type from 'llvm::LogicalResult test::TestConstMemorySpaceAttr::isValidLoad(mlir::Type,mlir::ptr::AtomicOrdering,mlir::IntegerAttr,llvm::function_ref<mlir::InFlightDiagnostic (void)>) const'
```

However, this patch changed both to `bool` and all other CIs are passing.

https://github.com/llvm/llvm-project/pull/137513