[Mlir-commits] [mlir] [mlir][ptr] Switch `LogicalResult` to `bool` in `MemorySpaceAttrInterrface` (PR #137513)

LLVM Continuous Integration llvmlistbot at llvm.org
Sun Apr 27 08:23:10 PDT 2025 

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `premerge-monolithic-windows` running on `premerge-windows-1` while building `mlir` at step 7 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/35/builds/9584

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 7 (build-unified-tree) failure: build (failure)
...
[20/4155] Building CXX object tools\mlir\lib\Dialect\Ptr\IR\CMakeFiles\obj.MLIRPtrDialect.dir\PtrTypes.cpp.obj
[21/4155] Building CXX object lib\Object\CMakeFiles\LLVMObject.dir\IRSymtab.cpp.obj
[22/4155] Linking CXX static library lib\LLVMObject.lib
[23/4155] Building CXX object tools\mlir\lib\Dialect\Ptr\IR\CMakeFiles\obj.MLIRPtrDialect.dir\PtrDialect.cpp.obj
[24/4155] Linking CXX executable bin\llvm-ar.exe
[25/4155] Generating ../../bin/llvm-lib.exe
[26/4155] Linking CXX executable bin\llvm-ctxprof-util.exe
[27/4155] Generating ../../bin/llvm-ranlib.exe
[28/4155] Generating ../../bin/llvm-dlltool.exe
[29/4155] Building CXX object tools\mlir\test\lib\Dialect\Test\CMakeFiles\MLIRTestDialect.dir\TestAttributes.cpp.obj
FAILED: tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestAttributes.cpp.obj 
sccache C:\BuildTools\VC\Tools\MSVC\14.29.30133\bin\Hostx64\x64\cl.exe  /nologo /TP -DGTEST_HAS_RTTI=0 -DMLIR_INCLUDE_TESTS -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools\mlir\test\lib\Dialect\Test -IC:\ws\buildbot\premerge-monolithic-windows\llvm-project\mlir\test\lib\Dialect\Test -Itools\mlir\include -IC:\ws\buildbot\premerge-monolithic-windows\llvm-project\mlir\include -Iinclude -IC:\ws\buildbot\premerge-monolithic-windows\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:preprocessor /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd5105 -wd4324 -wd4251 -wd4275 -w14062 -we4238 /Gw /O2 /Ob2  -MD  /EHs-c- /GR- -UNDEBUG -std:c++17 /showIncludes /Fotools\mlir\test\lib\Dialect\Test\CMakeFiles\MLIRTestDialect.dir\TestAttributes.cpp.obj /Fdtools\mlir\test\lib\Dialect\Test\CMakeFiles\MLIRTestDialect.dir\MLIRTestDialect.pdb /FS -c C:\ws\buildbot\premerge-monolithic-windows\llvm-project\mlir\test\lib\Dialect\Test\TestAttributes.cpp
C:\ws\buildbot\premerge-monolithic-windows\llvm-project\mlir\test\lib\Dialect\Test\TestAttributes.cpp(336): error C2556: 'bool test::TestConstMemorySpaceAttr::isValidLoad(mlir::Type,mlir::ptr::AtomicOrdering,mlir::IntegerAttr,llvm::function_ref<mlir::InFlightDiagnostic (void)>) const': overloaded function differs only by return type from 'llvm::LogicalResult test::TestConstMemorySpaceAttr::isValidLoad(mlir::Type,mlir::ptr::AtomicOrdering,mlir::IntegerAttr,llvm::function_ref<mlir::InFlightDiagnostic (void)>) const'
tools\mlir\test\lib\Dialect\Test\TestAttrDefs.h.inc(746): note: see declaration of 'test::TestConstMemorySpaceAttr::isValidLoad'
C:\ws\buildbot\premerge-monolithic-windows\llvm-project\mlir\test\lib\Dialect\Test\TestAttributes.cpp(334): error C2371: 'test::TestConstMemorySpaceAttr::isValidLoad': redefinition; different basic types
tools\mlir\test\lib\Dialect\Test\TestAttrDefs.h.inc(746): note: see declaration of 'test::TestConstMemorySpaceAttr::isValidLoad'
C:\ws\buildbot\premerge-monolithic-windows\llvm-project\mlir\test\lib\Dialect\Test\TestAttributes.cpp(342): error C2556: 'bool test::TestConstMemorySpaceAttr::isValidStore(mlir::Type,mlir::ptr::AtomicOrdering,mlir::IntegerAttr,llvm::function_ref<mlir::InFlightDiagnostic (void)>) const': overloaded function differs only by return type from 'llvm::LogicalResult test::TestConstMemorySpaceAttr::isValidStore(mlir::Type,mlir::ptr::AtomicOrdering,mlir::IntegerAttr,llvm::function_ref<mlir::InFlightDiagnostic (void)>) const'
tools\mlir\test\lib\Dialect\Test\TestAttrDefs.h.inc(747): note: see declaration of 'test::TestConstMemorySpaceAttr::isValidStore'
C:\ws\buildbot\premerge-monolithic-windows\llvm-project\mlir\test\lib\Dialect\Test\TestAttributes.cpp(340): error C2371: 'test::TestConstMemorySpaceAttr::isValidStore': redefinition; different basic types
tools\mlir\test\lib\Dialect\Test\TestAttrDefs.h.inc(747): note: see declaration of 'test::TestConstMemorySpaceAttr::isValidStore'
C:\ws\buildbot\premerge-monolithic-windows\llvm-project\mlir\test\lib\Dialect\Test\TestAttributes.cpp(350): error C2556: 'bool test::TestConstMemorySpaceAttr::isValidAtomicOp(mlir::ptr::AtomicBinOp,mlir::Type,mlir::ptr::AtomicOrdering,mlir::IntegerAttr,llvm::function_ref<mlir::InFlightDiagnostic (void)>) const': overloaded function differs only by return type from 'llvm::LogicalResult test::TestConstMemorySpaceAttr::isValidAtomicOp(mlir::ptr::AtomicBinOp,mlir::Type,mlir::ptr::AtomicOrdering,mlir::IntegerAttr,llvm::function_ref<mlir::InFlightDiagnostic (void)>) const'
tools\mlir\test\lib\Dialect\Test\TestAttrDefs.h.inc(748): note: see declaration of 'test::TestConstMemorySpaceAttr::isValidAtomicOp'
C:\ws\buildbot\premerge-monolithic-windows\llvm-project\mlir\test\lib\Dialect\Test\TestAttributes.cpp(348): error C2371: 'test::TestConstMemorySpaceAttr::isValidAtomicOp': redefinition; different basic types
tools\mlir\test\lib\Dialect\Test\TestAttrDefs.h.inc(748): note: see declaration of 'test::TestConstMemorySpaceAttr::isValidAtomicOp'
C:\ws\buildbot\premerge-monolithic-windows\llvm-project\mlir\test\lib\Dialect\Test\TestAttributes.cpp(359): error C2556: 'bool test::TestConstMemorySpaceAttr::isValidAtomicXchg(mlir::Type,mlir::ptr::AtomicOrdering,mlir::ptr::AtomicOrdering,mlir::IntegerAttr,llvm::function_ref<mlir::InFlightDiagnostic (void)>) const': overloaded function differs only by return type from 'llvm::LogicalResult test::TestConstMemorySpaceAttr::isValidAtomicXchg(mlir::Type,mlir::ptr::AtomicOrdering,mlir::ptr::AtomicOrdering,mlir::IntegerAttr,llvm::function_ref<mlir::InFlightDiagnostic (void)>) const'
tools\mlir\test\lib\Dialect\Test\TestAttrDefs.h.inc(749): note: see declaration of 'test::TestConstMemorySpaceAttr::isValidAtomicXchg'
C:\ws\buildbot\premerge-monolithic-windows\llvm-project\mlir\test\lib\Dialect\Test\TestAttributes.cpp(356): error C2371: 'test::TestConstMemorySpaceAttr::isValidAtomicXchg': redefinition; different basic types
tools\mlir\test\lib\Dialect\Test\TestAttrDefs.h.inc(749): note: see declaration of 'test::TestConstMemorySpaceAttr::isValidAtomicXchg'
C:\ws\buildbot\premerge-monolithic-windows\llvm-project\mlir\test\lib\Dialect\Test\TestAttributes.cpp(366): error C2556: 'bool test::TestConstMemorySpaceAttr::isValidAddrSpaceCast(mlir::Type,mlir::Type,llvm::function_ref<mlir::InFlightDiagnostic (void)>) const': overloaded function differs only by return type from 'llvm::LogicalResult test::TestConstMemorySpaceAttr::isValidAddrSpaceCast(mlir::Type,mlir::Type,llvm::function_ref<mlir::InFlightDiagnostic (void)>) const'
tools\mlir\test\lib\Dialect\Test\TestAttrDefs.h.inc(750): note: see declaration of 'test::TestConstMemorySpaceAttr::isValidAddrSpaceCast'
C:\ws\buildbot\premerge-monolithic-windows\llvm-project\mlir\test\lib\Dialect\Test\TestAttributes.cpp(365): error C2371: 'test::TestConstMemorySpaceAttr::isValidAddrSpaceCast': redefinition; different basic types
tools\mlir\test\lib\Dialect\Test\TestAttrDefs.h.inc(750): note: see declaration of 'test::TestConstMemorySpaceAttr::isValidAddrSpaceCast'
C:\ws\buildbot\premerge-monolithic-windows\llvm-project\mlir\test\lib\Dialect\Test\TestAttributes.cpp(374): error C2556: 'bool test::TestConstMemorySpaceAttr::isValidPtrIntCast(mlir::Type,mlir::Type,llvm::function_ref<mlir::InFlightDiagnostic (void)>) const': overloaded function differs only by return type from 'llvm::LogicalResult test::TestConstMemorySpaceAttr::isValidPtrIntCast(mlir::Type,mlir::Type,llvm::function_ref<mlir::InFlightDiagnostic (void)>) const'
tools\mlir\test\lib\Dialect\Test\TestAttrDefs.h.inc(751): note: see declaration of 'test::TestConstMemorySpaceAttr::isValidPtrIntCast'
C:\ws\buildbot\premerge-monolithic-windows\llvm-project\mlir\test\lib\Dialect\Test\TestAttributes.cpp(372): error C2371: 'test::TestConstMemorySpaceAttr::isValidPtrIntCast': redefinition; different basic types
tools\mlir\test\lib\Dialect\Test\TestAttrDefs.h.inc(751): note: see declaration of 'test::TestConstMemorySpaceAttr::isValidPtrIntCast'
[30/4155] Generating VCSVersion.inc
[31/4155] Linking CXX executable bin\llvm-profdata.exe
[32/4155] Building CXX object tools\mlir\test\lib\Dialect\Bufferization\CMakeFiles\MLIRBufferizationTestPasses.dir\TestTensorLikeAndBufferLike.cpp.obj
[33/4155] Building CXX object lib\CodeGen\AsmPrinter\CMakeFiles\LLVMAsmPrinter.dir\AsmPrinter.cpp.obj
[34/4155] Building CXX object tools\mlir\test\lib\Dialect\Test\CMakeFiles\MLIRTestDialect.dir\TestDialectInterfaces.cpp.obj
[35/4155] Building CXX object tools\mlir\test\lib\Dialect\Test\CMakeFiles\MLIRTestDialect.dir\TestTraits.cpp.obj
[36/4155] Building CXX object tools\mlir\test\lib\Dialect\Test\CMakeFiles\MLIRTestDialect.dir\TestOps.cpp.obj
[37/4155] Building CXX object tools\mlir\test\lib\Dialect\DLTI\CMakeFiles\MLIRDLTITestPasses.dir\TestDataLayoutQuery.cpp.obj
[38/4155] Building CXX object tools\mlir\test\lib\Dialect\Func\CMakeFiles\MLIRFuncTestPasses.dir\TestDecomposeCallGraphTypes.cpp.obj
[39/4155] Building CXX object tools\mlir\test\lib\Dialect\Test\CMakeFiles\MLIRTestDialect.dir\TestTypes.cpp.obj
[40/4155] Building CXX object tools\mlir\test\lib\Analysis\CMakeFiles\MLIRTestAnalysis.dir\DataFlow\TestDenseBackwardDataFlowAnalysis.cpp.obj
[41/4155] Building CXX object tools\mlir\test\lib\Dialect\Test\CMakeFiles\MLIRTestDialect.dir\TestDialect.cpp.obj
[42/4155] Building CXX object tools\mlir\test\lib\Conversion\FuncToLLVM\CMakeFiles\MLIRTestFuncToLLVM.dir\TestConvertFuncOp.cpp.obj

```

</details>

https://github.com/llvm/llvm-project/pull/137513

More information about the Mlir-commits mailing list