[Mlir-commits] [mlir] [mlir][linalg] Vectorization support for convolution of i1 type (PR #109480)

[Nirvedh Meshram]

================
@@ -2948,10 +2948,15 @@ struct Conv1DGenerator
     if (!setOperKind(reduceOp))
       return;
     auto maybeKind = getCombinerOpKind(reduceOp);
-    if (!maybeKind || (*maybeKind != vector::CombiningKind::ADD &&
----------------
nirvedhmeshram wrote:

`getCombinerOpKind` can return nullopt if we ever see an unsupported reduceOp, not sure if it is safe though, but better fail early incase that happens in the future?

https://github.com/llvm/llvm-project/pull/109480