[Mlir-commits] [mlir] [mlir][linalg] Vectorization support for convolution of i1 type (PR #109480)

Andrzej WarzyƄski llvmlistbot at llvm.org
Tue Sep 24 09:10:55 PDT 2024


================
@@ -2948,10 +2948,15 @@ struct Conv1DGenerator
     if (!setOperKind(reduceOp))
       return;
     auto maybeKind = getCombinerOpKind(reduceOp);
-    if (!maybeKind || (*maybeKind != vector::CombiningKind::ADD &&
----------------
banach-space wrote:

IIUC, it would be safe to assume here that `maybeKind` has a value, right?

https://github.com/llvm/llvm-project/pull/109480


More information about the Mlir-commits mailing list