[Mlir-commits] [mlir] [mlir][linalg] Vectorization support for convolution of i1 type (PR #109480)

Nirvedh Meshram llvmlistbot at llvm.org
Tue Sep 24 09:34:37 PDT 2024


================
@@ -2948,10 +2948,15 @@ struct Conv1DGenerator
     if (!setOperKind(reduceOp))
       return;
     auto maybeKind = getCombinerOpKind(reduceOp);
-    if (!maybeKind || (*maybeKind != vector::CombiningKind::ADD &&
----------------
nirvedhmeshram wrote:

I think the idea here is that in that case, some other logic can still vectorize the op rather then crashing in case we get `nullopt`

https://github.com/llvm/llvm-project/pull/109480


More information about the Mlir-commits mailing list