[Mlir-commits] [mlir] [mlir][vector] Implement speculation for vector.transferx ops (PR #111533)

[Jakub Kuderski]

kuhar wrote:

> @banach-space overall, I agree with you as what the best practice should be, but my reading of the guidelines is different:
> 
> > This cycle continues until all requests and comments have been addressed and a reviewer accepts the patch with a Looks good to me or LGTM
> 
> This presents two criteria: (1) there are no outstanding comments that require resolution, (2) the PR received at least one LGTM. It doesn't require you to receive a LGTM from all reviewers / commenters. IME, very often this is a judgement call of whether you reasonably believe that all comments have been addressed, and I see waiting for a confirmation as more of a good practice.

For example, you typically wouldn't wait for approval from all 'drive-by' reviewers who point out typos and other nits.

https://github.com/llvm/llvm-project/pull/111533