[Mlir-commits] [mlir] [mlir][vector] Implement speculation for vector.transferx ops (PR #111533)

[Andrzej Warzyński]

banach-space wrote:

> This presents two criteria: (...) (2) the PR received at least one LGTM.

Note that your LGTM landed before my comments and further changes in the latest commit. In situations like this, good practice (to me) would be either:
*  the original reviewer re-confirming their LGTM: "This still looks good to me and all other comments have also been addressed, good to go!", or
* the outstanding reviewers approving, or
* the author leaving a note: "Not waiting for further LGTM, landing as is because ...".

> I see waiting for a confirmation as more of a good practice.

Agreed and that's exactly what I'm after :-) 

>  I misunderstood the only review comment being a minor actionable comment about tests as a signal that it should be fine to land once it's fixed as you seemed satisfied with the explanation provided before.

And I should've been clearer.

Anyway, all good, thanks for the discussion and for the contribution! 

https://github.com/llvm/llvm-project/pull/111533