[Mlir-commits] [mlir] [mlir][vector] Implement speculation for vector.transferx ops (PR #111533)

[Kunwar Grover]

Groverkss wrote:

> @Groverkss You have landed this change without all of the active reviewers explicitly approving it, please avoid that. As per [contribution guidelines](https://llvm.org/docs/Contributing.html#how-to-submit-a-patch):
> 
> > Please address the feedback and re-post an updated version of your patch. This cycle continues until all requests and comments have been addressed and a reviewer accepts the patch with a Looks good to me or LGTM. Once that is done the change can be committed.
> 
> I read that as "if a reviewer leaves a comment, please address that and wait for them to confirm that their comments have been addressed by posting **LGTM**". That last part didn't happen, hence this message.
> 
> I'm not an expert on this area, but this changes looks good to me and I appreciate you did address my comments. Still, I'd appreciate if you followed the process in the future, thanks!

Ah sorry, I misunderstood the only review comment being a minor comment about tests as a signal that it should be fine to land once it's fixed as you seemed satisfied with the explanation provided before. But I should have taken more caution and waited, as I wasn't in any hurry to land it and it's always nicer to get more eyes here. I really appreciate the review and hopefully, this clears why I landed it and I'm happy to still address any post review comments :)

https://github.com/llvm/llvm-project/pull/111533