[llvm-dev] [RFC] Adding a char set converter to Support library

[Hubert Tong via llvm-dev]

On Mon, Oct 5, 2020 at 1:27 PM Chris Tetreault via llvm-dev <
llvm-dev at lists.llvm.org> wrote:

> Kai,
>
>    I added some comments to your patch, but my main takeaway is that I
> think the iconv dependency should probably be removed regardless of license
> uncertainty. I think we should define a set of conversions that we support
> and only support those. If convertWithTable is good enough for us, then we
> don't need iconv. From what I can tell by reading the code, iconv provides
> the possibility of supporting additional conversions. However, if
> CharSetConverter::create can return a converter on one person's machine,
> but not mine because I don't have an optional dependency installed, that's
> going to be very annoying.
>
That's a good argument for having a mapping of recognized encoding
identifiers as part of the configuration or packaging process. I am not
sure this makes the case for avoiding iconv entirely.


>
> Thanks,
>    Christopher Tetreault
>
> -----Original Message-----
> From: llvm-dev <llvm-dev-bounces at lists.llvm.org> On Behalf Of Kai Peter
> Nacke via llvm-dev
> Sent: Friday, October 2, 2020 10:45 AM
> To: Anton Korobeynikov <anton at korobeynikov.info>
> Cc: llvm-dev <llvm-dev at lists.llvm.org>; Yusra Syeda <Yusra.Syeda at ibm.com>
> Subject: [EXT] Re: [llvm-dev] [RFC] Adding a char set converter to Support
> library
>
> My understanding is that dynamically linking should pose no problem, but I
> am no lawyer. On Linux, glibc is also under LGPL license, and LLVM usually
> links against it.
> (There is really no need for us to depend on libiconv. If it is deemed to
> risky, then I can dropped it.)
>
>
>
> From:   Anton Korobeynikov <anton at korobeynikov.info>
> To:     Kai Peter Nacke <kai.nacke at de.ibm.com>
> Cc:     llvm-dev <llvm-dev at lists.llvm.org>, Yusra Syeda
> <Yusra.Syeda at ibm.com>
> Date:   02.10.2020 19:08
> Subject:        [EXTERNAL] Re: [llvm-dev] [RFC] Adding a char set
> converter to Support library
>
>
>
> As far as I remember, libiconv is under LGPL. Will this cause any troubles?
>
> On Fri, Oct 2, 2020 at 7:13 PM Kai Peter Nacke via llvm-dev <
> llvm-dev at lists.llvm.org> wrote:
> >
> > Hi!
> >
> > On z/OS, there is the need to convert strings from EBCDIC to UTF-8 and
> > vice versa.
> > Using the POSIX iconv functions has some challenges, so I created a
> small
> > wrapper
> > around this functionality to get the same result on all platforms.
> > This functionality is required for reading and writing GOFF object
> > files and can also be
> used
> > in the
> > frontend.
> > I put up the code on Phabricator
> https://reviews.llvm.org/D88741
> . Please
> > add your
> > comments to the review if you are interested in this topic.
> >
> > Best regards,
> > Kai
> >
> > Kai Nacke
> > IT Architect
> >
> > IBM Deutschland GmbH
> > Vorsitzender des Aufsichtsrats: Sebastian Krause
> > Geschäftsführung: Gregor Pillen (Vorsitzender), Agnes Heftberger,
> Norbert
> > Janzen, Markus Koerner, Christian Noll, Nicole Reimer Sitz der
> > Gesellschaft: Ehningen / Registergericht: Amtsgericht
> Stuttgart,
> > HRB 14562 / WEEE-Reg.-Nr. DE 99369940
> >
> > _______________________________________________
> > LLVM Developers mailing list
> > llvm-dev at lists.llvm.org
> >
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
>
>
>
> --
> With best regards, Anton Korobeynikov
> Department of Statistical Modelling, Saint Petersburg State University
>
>
>
>
>
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20201007/d3feeb14/attachment.html>