<div dir="ltr"><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Oct 5, 2020 at 1:27 PM Chris Tetreault via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Kai,<br>
<br>
I added some comments to your patch, but my main takeaway is that I think the iconv dependency should probably be removed regardless of license uncertainty. I think we should define a set of conversions that we support and only support those. If convertWithTable is good enough for us, then we don't need iconv. From what I can tell by reading the code, iconv provides the possibility of supporting additional conversions. However, if CharSetConverter::create can return a converter on one person's machine, but not mine because I don't have an optional dependency installed, that's going to be very annoying.<br></blockquote><div>That's a good argument for having a mapping of recognized encoding identifiers as part of the configuration or packaging process. I am not sure this makes the case for avoiding iconv entirely.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Thanks,<br>
Christopher Tetreault<br>
<br>
-----Original Message-----<br>
From: llvm-dev <<a href="mailto:llvm-dev-bounces@lists.llvm.org" target="_blank">llvm-dev-bounces@lists.llvm.org</a>> On Behalf Of Kai Peter Nacke via llvm-dev<br>
Sent: Friday, October 2, 2020 10:45 AM<br>
To: Anton Korobeynikov <<a href="mailto:anton@korobeynikov.info" target="_blank">anton@korobeynikov.info</a>><br>
Cc: llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>>; Yusra Syeda <<a href="mailto:Yusra.Syeda@ibm.com" target="_blank">Yusra.Syeda@ibm.com</a>><br>
Subject: [EXT] Re: [llvm-dev] [RFC] Adding a char set converter to Support library<br>
<br>
My understanding is that dynamically linking should pose no problem, but I am no lawyer. On Linux, glibc is also under LGPL license, and LLVM usually links against it.<br>
(There is really no need for us to depend on libiconv. If it is deemed to risky, then I can dropped it.)<br>
<br>
<br>
<br>
From: Anton Korobeynikov <<a href="mailto:anton@korobeynikov.info" target="_blank">anton@korobeynikov.info</a>><br>
To: Kai Peter Nacke <<a href="mailto:kai.nacke@de.ibm.com" target="_blank">kai.nacke@de.ibm.com</a>><br>
Cc: llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>>, Yusra Syeda<br>
<<a href="mailto:Yusra.Syeda@ibm.com" target="_blank">Yusra.Syeda@ibm.com</a>><br>
Date: 02.10.2020 19:08<br>
Subject: [EXTERNAL] Re: [llvm-dev] [RFC] Adding a char set<br>
converter to Support library<br>
<br>
<br>
<br>
As far as I remember, libiconv is under LGPL. Will this cause any troubles?<br>
<br>
On Fri, Oct 2, 2020 at 7:13 PM Kai Peter Nacke via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<br>
><br>
> Hi!<br>
><br>
> On z/OS, there is the need to convert strings from EBCDIC to UTF-8 and<br>
> vice versa.<br>
> Using the POSIX iconv functions has some challenges, so I created a<br>
small<br>
> wrapper<br>
> around this functionality to get the same result on all platforms.<br>
> This functionality is required for reading and writing GOFF object<br>
> files and can also be<br>
used<br>
> in the<br>
> frontend.<br>
> I put up the code on Phabricator<br>
<a href="https://reviews.llvm.org/D88741" rel="noreferrer" target="_blank">https://reviews.llvm.org/D88741</a><br>
. Please<br>
> add your<br>
> comments to the review if you are interested in this topic.<br>
><br>
> Best regards,<br>
> Kai<br>
><br>
> Kai Nacke<br>
> IT Architect<br>
><br>
> IBM Deutschland GmbH<br>
> Vorsitzender des Aufsichtsrats: Sebastian Krause<br>
> Geschäftsführung: Gregor Pillen (Vorsitzender), Agnes Heftberger,<br>
Norbert<br>
> Janzen, Markus Koerner, Christian Noll, Nicole Reimer Sitz der<br>
> Gesellschaft: Ehningen / Registergericht: Amtsgericht<br>
Stuttgart,<br>
> HRB 14562 / WEEE-Reg.-Nr. DE 99369940<br>
><br>
> _______________________________________________<br>
> LLVM Developers mailing list<br>
> <a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
<br>
<br>
<br>
<br>
--<br>
With best regards, Anton Korobeynikov<br>
Department of Statistical Modelling, Saint Petersburg State University<br>
<br>
<br>
<br>
<br>
<br>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div></div>