[llvm-dev] Commits as new contributor

Florian Hahn via llvm-dev llvm-dev at lists.llvm.org
Sun Mar 1 07:24:23 PST 2020


> On 1 Mar 2020, at 14:44, Stefanos Baziotis via llvm-dev <llvm-dev at lists.llvm.org> wrote:
> I recently was granted commit access, but I'm not really sure what is the process.
> The developer policy states:
> "You are granted commit-after-approval to all parts of LLVM. To get approval, submit a patch to llvm-commits. When approved, you may commit it yourself."
> Do I have to send the patch to llvm-commits via email and wait for approval even when the patch has been accepted in the reviews (i.e. Phabricator)  ?

Approval via Phabricator is fine. LLVM-commits (or the relevant sub project list) should always be a subscriber of reviews in Phabricator, so the approval is recorded there too.

It may be worth updating the wording in the docs to explicitly mention Phabricator.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200301/247a6aec/attachment.html>

More information about the llvm-dev mailing list