[llvm-dev] Commits as new contributor

Michael Kruse via llvm-dev llvm-dev at lists.llvm.org
Sun Mar 1 07:21:27 PST 2020


the docs are assuming that the llvm-commits mailing list is the
primary location where the review takes place. Phabricator was added
as a helper, and will also send all comments to llvm-commits.

In practice, llvm-commits has too much traffic, so only few people
will look at llvm-commits. Review takes place almost exclusively on

That is, do as you did before. The only change with commit access is
that instead of requesting someone to commit for you, you can push
your commit yourself to github after a LGTM/approval on Phabricator.
The approval has already been sent to llvm-commits by Phabricator.


Am So., 1. März 2020 um 08:44 Uhr schrieb Stefanos Baziotis via
llvm-dev <llvm-dev at lists.llvm.org>:
> Hi everyone,
> I recently was granted commit access, but I'm not really sure what is the process.
> The developer policy states:
> "You are granted commit-after-approval to all parts of LLVM. To get approval, submit a patch to llvm-commits. When approved, you may commit it yourself."
> Do I have to send the patch to llvm-commits via email and wait for approval even when the patch has been accepted in the reviews (i.e. Phabricator)  ?
> Best,
> Stefanos
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

More information about the llvm-dev mailing list