<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div dir="ltr">Hi,</div><div dir="ltr"><br></div><div dir="ltr"><br><blockquote type="cite">On 1 Mar 2020, at 14:44, Stefanos Baziotis via llvm-dev <llvm-dev@lists.llvm.org> wrote:<br></blockquote></div><blockquote type="cite"><div dir="ltr"><div dir="ltr"><div dir="ltr"><br>I recently was granted commit access, but I'm not really sure what is the process.<br>The developer policy states:<br>"<span style="text-align:left;color:rgb(0,0,0);text-transform:none;text-indent:0px;letter-spacing:normal;font-family:"Lucida Grande","Lucida Sans Unicode","Geneva","Verdana",sans-serif;font-size:14px;font-style:normal;font-variant:normal;font-weight:400;text-decoration:none;word-spacing:0px;display:inline;white-space:normal;float:none;background-color:rgb(255,255,255)">You are granted </span><em style="text-align:left;color:rgb(0,0,0);text-transform:none;text-indent:0px;letter-spacing:normal;font-size:14px;font-style:italic;font-variant:normal;font-weight:400;text-decoration:none;word-spacing:0px;white-space:normal">commit-after-approval</em><span style="text-align:left;color:rgb(0,0,0);text-transform:none;text-indent:0px;letter-spacing:normal;font-family:"Lucida Grande","Lucida Sans Unicode","Geneva","Verdana",sans-serif;font-size:14px;font-style:normal;font-variant:normal;font-weight:400;text-decoration:none;word-spacing:0px;display:inline;white-space:normal;float:none;background-color:rgb(255,255,255)"> to all parts of LLVM. To get
approval, submit a </span><a class="gmail-reference gmail-internal" style="text-align:left;color:rgb(202,121,0);text-transform:none;text-indent:0px;letter-spacing:normal;font-size:14px;font-style:normal;font-variant:normal;font-weight:400;text-decoration:none;word-spacing:0px;white-space:normal" href="https://llvm.org/docs/DeveloperPolicy.html#patch">patch</a><span style="text-align:left;color:rgb(0,0,0);text-transform:none;text-indent:0px;letter-spacing:normal;font-family:"Lucida Grande","Lucida Sans Unicode","Geneva","Verdana",sans-serif;font-size:14px;font-style:normal;font-variant:normal;font-weight:400;text-decoration:none;word-spacing:0px;display:inline;white-space:normal;float:none;background-color:rgb(255,255,255)"> to </span><a class="gmail-reference external" style="text-align:left;color:rgb(202,121,0);text-transform:none;text-indent:0px;letter-spacing:normal;font-size:14px;font-style:normal;font-variant:normal;font-weight:400;text-decoration:none;word-spacing:0px;white-space:normal" href="http://lists.llvm.org/mailman/listinfo/llvm-commits">llvm-commits</a><span style="text-align:left;color:rgb(0,0,0);text-transform:none;text-indent:0px;letter-spacing:normal;font-family:"Lucida Grande","Lucida Sans Unicode","Geneva","Verdana",sans-serif;font-size:14px;font-style:normal;font-variant:normal;font-weight:400;text-decoration:none;word-spacing:0px;display:inline;white-space:normal;float:none;background-color:rgb(255,255,255)">. When approved,
you may commit it yourself."<br><br>Do I have to send the patch to llvm-commits via email and wait for approval even when the patch has been accepted in the reviews (i.e. Phabricator) ?<br><br></span></div></div></div></blockquote><div><br></div><div><br></div>Approval via Phabricator is fine. LLVM-commits (or the relevant sub project list) should always be a subscriber of reviews in Phabricator, so the approval is recorded there too.<div><br></div><div>It may be worth updating the wording in the docs to explicitly mention Phabricator.</div><div><br></div><div>Cheers</div><div>Florian </div></body></html>