[llvm-dev] [cfe-dev] Phabricator -> GitHub PRs?
Hubert Tong via llvm-dev
llvm-dev at lists.llvm.org
Wed Jan 22 14:40:54 PST 2020
On Wed, Jan 22, 2020 at 4:40 PM David Greene <greened at obbligato.org> wrote:
> Hubert Tong <hubert.reinterpretcast at gmail.com> writes:
> > The update process in Phab in rather manual and it does lead to more
> > The GitHub force push risks loss of context for earlier comments (not
> > in terms of display, like viewing older comments on a later diff in
> > Another issue with the GitHub workflow is that there is no metadata
> > the corresponding commits between two versions of the same patch series.
> > Reviewers looking at a patch-series-as-GitHub-PR that is a refresh of an
> > older patch-series-as-GitHub-PR are less likely to notice the previous
> > discussion than the corresponding Phab workflow.
> I read this as the refresh being an entirely new GitHub PR. Is that
> right? Normally I would expect the same PR to be used but the rebase
> would cause a force-push of the branch which would update the PR with
> the new commits but might lose comments. It's that later part I'm
> unsure about. It would seem odd to me to open an entirely new PR due to
> a rebase/update of commits to respond to review.
Use of force push damages the ability to retrieve context on older
comments. I am not sure of the reason for the case I observed, but the
context vanished within a week in one instance.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-dev