[llvm-dev] [cfe-dev] Phabricator -> GitHub PRs?

David Greene via llvm-dev llvm-dev at lists.llvm.org
Thu Jan 23 08:37:28 PST 2020

Hubert Tong <hubert.reinterpretcast at gmail.com> writes:

>> I read this as the refresh being an entirely new GitHub PR.  Is that
>> right?  Normally I would expect the same PR to be used but the rebase
>> would cause a force-push of the branch which would update the PR with
>> the new commits but might lose comments.  It's that later part I'm
>> unsure about.  It would seem odd to me to open an entirely new PR due to
>> a rebase/update of commits to respond to review.
> Use of force push damages the ability to retrieve context on older
> comments. I am not sure of the reason for the case I observed, but the
> context vanished within a week in one instance.

Does "vanish" mean it was completely gone, or just hidden in some way?


More information about the llvm-dev mailing list