[llvm-dev] Allowing PRs on GitHub for some subprojects

[Johannes Doerfert via llvm-dev]

On 02/20, Louis Dionne via llvm-dev wrote:
> I know there has been significant discussion about "moving" from
> Phabricator to GitHub reviews and pull requests, etc. I'm not
> suggesting that we do anything in terms of global LLVM policy.
> However, as a maintainer of libc++, I commit __a lot__ of other
> people's code for them. It would be a huge time saver for me if I
> could nicely suggest to contributors (not force them) to use PRs
> instead of Phabricator for their contributions. It would also handle
> commit attribution properly, which is a pain right now.

Don't take this as me telling you it is "actually simple". I am
interested what about the contribution is problematic? If the libc++
system doesn't have more requirements than the rest of LLVM there might
be ways to make it less painful. FWIW, here is what I do, and I know not
everyone wants to use `arc`. Ina script this could potentially reduce
the pain. Again, this is not meant to tell you it is simple or your
problems are not real.

arc patch DXXXX
git pull --rebase origin master
arc amend
arcfilter        // see below
git llvm push master


arcfilter () { git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:/' | git commit --amend -F - }

> Would it be possible to allow GitHub PRs to be submitted on the
> monorepo so as to let individual sub-projects deal with it however
> they please? I've spoken to numerous people involved in libc++
> development and they would like to start submitting PRs (and for the
> others, we'll still accept Phabricator reviews). Perhaps it is
> possible to setup some kind of filter such that PRs touching only
> libcxx/ and libcxxabi/ can be submitted, but otherwise they're closed
> by the bot?

TBH, I feel this is yet another way of splitting the community and in
the end complicating things even more. I mean, since recently if you
want to ask a question there were the *-dev lists and the IRC. Now we
have discourse, discord on top of that with some people monitoring only
one of these and others required to monitor both. Duplicating the way we
do reviews is similarly going to require people that want to be informed
to duplicate their lookups.

Cheers,
  Johannes

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200220/0b1f4d70/attachment.sig>