[llvm-dev] Allowing PRs on GitHub for some subprojects

Chris Lattner via llvm-dev llvm-dev at lists.llvm.org
Thu Feb 20 20:05:37 PST 2020


On Feb 20, 2020, at 11:25 AM, Johannes Doerfert via llvm-dev <llvm-dev at lists.llvm.org> wrote:
> 
>> Would it be possible to allow GitHub PRs to be submitted on the
>> monorepo so as to let individual sub-projects deal with it however
>> they please? I've spoken to numerous people involved in libc++
>> development and they would like to start submitting PRs (and for the
>> others, we'll still accept Phabricator reviews). Perhaps it is
>> possible to setup some kind of filter such that PRs touching only
>> libcxx/ and libcxxabi/ can be submitted, but otherwise they're closed
>> by the bot?
> 
> TBH, I feel this is yet another way of splitting the community and in
> the end complicating things even more. I mean, since recently if you
> want to ask a question there were the *-dev lists and the IRC. Now we
> have discourse, discord on top of that with some people monitoring only
> one of these and others required to monitor both. Duplicating the way we
> do reviews is similarly going to require people that want to be informed
> to duplicate their lookups.

I agree with Johannes here.  Although I am one of the (many) people who would love to see us move from Phabricator to GitHub PRs, I think it is super important that we do the transition all at once to keep the LLVM community together.  I’m already concerned about the fragmentation the discourse server is causing, e.g. MLIR not using a -dev list.  I’d rather the community processes stay consistent.

-Chris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200220/106c88b9/attachment.html>


More information about the llvm-dev mailing list