[llvm-dev] Allowing PRs on GitHub for some subprojects

[Mehdi AMINI via llvm-dev]

Hi,

This was part of what I proposed when we integrated MLIR in LLVM (
http://lists.llvm.org/pipermail/llvm-dev/2019-November/136579.html ), we
were already using pull-requests before and had CI infrastructure already
built for it.
Ultimately we didn't press this further, divergence inside the repo /
between the subproject does not seems desirable in my opinion:
- it creates confusion: "why is this repository having pull-requests and
reviews on GitHub but my pull-request gets automatically closed?", "I
followed doc X"
- the lack of Herald on GitHub makes it so that we can't filter / subscribe
automatically to individual pull-requests: this was the major blocker in my
opinion, I couldn't find a solution to this and I believe it is critical.
- it does not favor to build common tooling: the recent work on enabling
pre-submit CI tests on Phabricator is valuable and I'm looking forward to
get this extended. But splitting the various ways of contributing to the
repo just means more infrastructure to build to sustain this kind of
efforts. (the infrastructure is easier built on GitHub by the way, but that
is an argument in favor of migrating from Phab to GH for the full-project).

So in summary: I'd rather find a path for the full-project to do this, but
acknowledging that there are few blockers to solve before getting there (cf
other threads on the topic).

-- 
Mehdi

On Thu, Feb 20, 2020 at 10:21 AM Louis Dionne via llvm-dev <
llvm-dev at lists.llvm.org> wrote:

> Hi,
>
> I know there has been significant discussion about "moving" from
> Phabricator to GitHub reviews and pull requests, etc. I'm not suggesting
> that we do anything in terms of global LLVM policy. However, as a
> maintainer of libc++, I commit __a lot__ of other people's code for them.
> It would be a huge time saver for me if I could nicely suggest to
> contributors (not force them) to use PRs instead of Phabricator for their
> contributions. It would also handle commit attribution properly, which is a
> pain right now.
>
> Would it be possible to allow GitHub PRs to be submitted on the monorepo
> so as to let individual sub-projects deal with it however they please? I've
> spoken to numerous people involved in libc++ development and they would
> like to start submitting PRs (and for the others, we'll still accept
> Phabricator reviews). Perhaps it is possible to setup some kind of filter
> such that PRs touching only libcxx/ and libcxxabi/ can be submitted, but
> otherwise they're closed by the bot?
>
> Cheers,
> Louis
>
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200220/3b81d74f/attachment.html>