[llvm-dev] Enable Contributions Through Pull-request For LLVM
Francesco Petrogalli via llvm-dev
llvm-dev at lists.llvm.org
Thu Nov 14 13:24:53 PST 2019
+1 from me, if just for the sake of lowering the entry barrier.
As for some of the discussion this thread has originated (apologies if I missed some of the conversation around them):
* Phabricator vs GitHub: they both have good and bad features. It will always be a matter of personal preference. IMHO, more solid criterias for a choice are 1) keep everything (or as much as we can) in a single place, and as I already said 2) lower the entry barrier.
* Concerns around export control of GitHub to certain countries. Surely in such case the major concerns wouldn’t be for doing the code reviews, but for getting access to the code? Speaking off which: do we mirror the monorepo somewhere else other than just having it on GitHub?
* Low code quality of new contributions, and possible breakage of other people builds: can we have CI integrated with GitHub? That should lower a lot the risk of having incoming things that break things.
> On Nov 6, 2019, at 11:32 PM, Mehdi AMINI via llvm-dev <llvm-dev at lists.llvm.org> wrote:
> Hi all,
> Now that we're on GitHub, we can discuss about pull-requests.
> I'd like to propose to enable pull-request on GitHub, as a first step as an experimental channel alongside the existing methods for contributing to LLVM.
> This would allow to find workflow issues and address them, and also LLVM contributors in general to start getting familiar with pull-requests without committing to switching to pull-requests immediately. The community should evaluate after a few months what would the next steps be.
> GitHub pull-requests is the natural way to contribute to project hosted on GitHub: this feature is so core to GitHub that there is no option to disable it!
> The current proposal is to allow to integrate contributions to the LLVM project directly from pull-requests. In particular the exact setup would be the following:
> - Contributors should use their own fork and push a branch in their fork.
> - Reviews can be performed on GitHub. The canonical tools are still the mailing-list and Phabricator: a reviewer can request the review to move to Phabricator.
> - The only option available will be to “squash and merge”. This mode of review matches the closest our current workflow (both phabricator and mailing-list): conceptually independent contributions belongs to separate review threads, and thus separate pull-requests.
> This also allow the round of reviews to not force-push the original branch and accumulate commits: this keeps the contextual history of comments and allow to visualize the incremental diff across revision of the pull-request.
> - Upon “merge” of a pull-request: history is linear and a single commit lands in master after review is completed.
> As an alternative staging proposal: we could enable pull-requests only for a small subset of sub-projects in LLVM (i.e. not LLVM/clang to begin with for example) in the repo. In this case, we would propose to begin with the MLIR project (as soon as it gets integrated in the monorepo). This would be a good candidate to be the guinea pig for this process since it does not yet have a wide established community of contributors, and the current contributors are already exclusively using pull-requests.
> Here is a more complete doc on the topic: https://docs.google.com/document/d/1DSHQrfydSjoqU9zEnj3rIcds6YN59Jxc37MdiggOyaI
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
More information about the llvm-dev